Skip to content

Adding cfw faces#56

Open
mesteryui wants to merge 9 commits intoprotesilaos:mainfrom
mesteryui:main
Open

Adding cfw faces#56
mesteryui wants to merge 9 commits intoprotesilaos:mainfrom
mesteryui:main

Conversation

@mesteryui
Copy link

First I as a user of Emacs for android use modifier-bar-mode in that version I added it to do that the modifier-bar items can be readed by the user, also I added the cfw faces to do that things as buttons of calendar view looks well, also I'm not an expert and if there's something that can be corrected that would be great I'm not too good in face editing

@protesilaos
Copy link
Owner

Hello @mesteryui! I have not had time to set up calfw. Can you give me a minimal setup for it? I need to see how it looks in context. What you have there seems fine, but maybe there is more.

About modifier-bar-mode, I cannot find such a face. How does it look by default?

@mesteryui
Copy link
Author

The modifier bar mode I set in the Emacs version for android because and I see in that version that using that the text in the bar with modifier keys sees well I only tested and it works but I don't know really how to set that in that context and in the calfw I did a basic that does the calfw interface looks some better of it is now, does that menu elements can be view by the user

@mesteryui
Copy link
Author

If you want you can comment the modifier-bar-mode or delete it was a test that really for most users doesn't affect I think

@mesteryui
Copy link
Author

I sen after how looks the faces I set for calfw

@mesteryui
Copy link
Author

imagen
This is the way cfw is when the face is applied

@protesilaos
Copy link
Owner

The calfw will need more work. If you notice, the purple for the 1st of May is too dark. The red in the 23rd of April is ont right, nor is the cyan below it. The green in the 1st April is dark as well. Finally, the red of the sundays is not appropriate.

I have to review calfw as soon as I can because there are a lot of faces here that need to be handled holistically.

@mesteryui
Copy link
Author

Yes I also don't understand much about the face setting in general but this also have that problem, I'll have much to do currently because of that I would work about that in a near future I think

@mesteryui
Copy link
Author

Hello Prot, I added some improvments for calfw theme

@mesteryui
Copy link
Author

image
image

mesteryui added 2 commits May 15, 2025 13:51
…ks to package-lint

tool I removed it to mantain compatibility without problems because I'm not sure how to implement
@mesteryui
Copy link
Author

As I described in commit I remove the modifier bar-mode because a warning that tells that with emacs minium version of package isn't compatible, I know begin to use tools as package-lint to ensure everything is well

@mesteryui mesteryui changed the title Things that I think can be good to the theme Adding cfw faces Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants